Template talk:Quote
|
|
Fix the Second Named Argument
 | This suggestion was implemented. |
The template fails to produce correct output when supplied with a named second parameter. This can easily be verified with some test cases. A test case containing no named parameters works as intended, producing:
I'm going to choose a life without Evas as well.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
However, naming the second parameter with all possible variations except one no longer produces the desired output: the citation is missing entirely.
I won't rewind time or revert the world.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
I'm just going to rewrite the world into one that doesn't have Evas.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
A world where new people can live.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
Birth of a new world.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
Neon genesis.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
Yeah.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
And besides, Ms. Mari will come for me.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
A consequence of this incorrect implementation is that the 2 named parameter still works.
So please, don't worry.
— 碇シンジ, シン・エヴァンゲリオン劇場版𝄇
It appears that this is an issue with nesting template argument substitutions, the fix for which is simple to implement (moving some end braces).
With regards to the second parameter, its labelling is wildly inconsistent: there is a possibility for the misuse of a given parameter name that would contradict the intention or content of the citation. Separating the implications of the parameter into the optional sign and source parameters—for the person being quoted and the source of the quote, respectively—in accordance with the original MediaWiki implementation would remove the need for overloading the parameter and grant greater flexibility when citing sources. Additionally, the citation line is indiscriminately italicized.
I have opted to not fix the template's immediate issue until I get an OK from some higher up. I'd like to see my other suggestion implemented, but understandably, it's of low priority. —結衣 (talk) 03:37, 12 May 2022 (UTC)
Actually fix and update the template
The recent change to the template has fixed the issue incorrectly: while the template now recognizes and substitutes named aliases for the second parameter, it actually now has seven non-positional, named arguments instead of two, and the second parameter in practice still has no named aliases. For example, the WikiText
{{quote|content=I have seen what that poor sap saw, hundreds, no, thousands of times, maybe more.|1=One should not see this.|sign=Binah, <cite>Lobotomy Corporation</cite>|cite=,but|author= there's|by=even|personquoted=more|source=stuff|quotesource=you|2=aren't supposed to see.}}
produces the unintended output
I have seen what that poor sap saw, hundreds, no, thousands of times, maybe more.
— Binah, Lobotomy Corporation
whereas one would instead expect something like the following (produced using my own template implementation):
Another issue is that the <cite> tag should not contain the author of the quote per the W3 specification. I've taken the liberty of mirroring with minor changes the Template:Quote template from MediaWiki, which features the same syntax, separated author and source arguments, and preferred use of the <cite> tag. I would recommend replacing the existing template with my implementation. —結衣 (talk) 00:28, 17 August 2022 (UTC)
